Don't get and release the context for each point, just once, speeds up

2006-08-07  Richard Hult  <richard@imendio.com>

	* gdk/quartz/gdkdrawable-quartz.c (gdk_quartz_draw_points): Don't
	get and release the context for each point, just once, speeds up
	drawing many points a lot.

diff --git a/ChangeLog b/ChangeLog
index 0d0391d99f2882161dcda8b679849a2d1dcedec0..fe30f5f1ce1085e66b726c1db07914f73a534800 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-08-07  Richard Hult  <richard@imendio.com>
+
+       * gdk/quartz/gdkdrawable-quartz.c (gdk_quartz_draw_points): Don't
+       get and release the context for each point, just once, speeds up
+       drawing many points a lot.
+
 2006-08-07  Michael Natterer  <mitch@imendio.com>
 
        * gtk/gtkdnd-quartz.c (gtk_drag_dest_unset): need to disconnect

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 0d0391d99f2882161dcda8b679849a2d1dcedec0..fe30f5f1ce1085e66b726c1db07914f73a534800 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,9 @@
+2006-08-07  Richard Hult  <richard@imendio.com>
+
+       * gdk/quartz/gdkdrawable-quartz.c (gdk_quartz_draw_points): Don't
+       get and release the context for each point, just once, speeds up
+       drawing many points a lot.
+
 2006-08-07  Michael Natterer  <mitch@imendio.com>
 
        * gtk/gtkdnd-quartz.c (gtk_drag_dest_unset): need to disconnect

diff --git a/gdk/quartz/gdkdrawable-quartz.c b/gdk/quartz/gdkdrawable-quartz.c
index f25626255554a4ba9661043f11fa990e8c43df36..94b68c8e36804e7f898565759e5789551ddb1884 100644 (file)
--- a/gdk/quartz/gdkdrawable-quartz.c
+++ b/gdk/quartz/gdkdrawable-quartz.c
@@ -326,15 +326,24 @@ gdk_quartz_draw_points (GdkDrawable *drawable,
                       GdkPoint    *points,
                       gint         npoints)
 {
+  CGContextRef context = gdk_quartz_drawable_get_context (drawable, FALSE);
   int i;
 
+  if (!context)
+    return;
+
+  gdk_quartz_update_context_from_gc (context, gc);
+  gdk_quartz_set_context_fill_color_from_pixel (context, gdk_drawable_get_colormap (drawable),
+                                               _gdk_gc_get_fg_pixel (gc));
+
   /* Just draw 1x1 rectangles */
   for (i = 0; i < npoints; i++) 
     {
-      gdk_draw_rectangle (drawable, gc, TRUE, 
-                         points[i].x, points[i].y,
-                         1, 1);
+      CGRect rect = CGRectMake (points[i].x + 0.5, points[i].y + 0.5, 1, 1);
+      CGContextFillRect (context, rect);
     }
+
+  gdk_quartz_drawable_release_context (drawable, context);
 }
 
 static void